From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] pcap: fix compilation error introduced by kvargs Date: Wed, 19 Mar 2014 14:44:31 +0100 Message-ID: <1559530.9fFZGPfV9j@xps13> References: <1393797088-25730-1-git-send-email-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org, mirots-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org To: Olivier Matz Return-path: In-Reply-To: <1393797088-25730-1-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 02/03/2014 22:51, Olivier Matz : > Due to a merge conflict between commits 4c745617a1 and 9d5752d80, > rte_eth_pcap.c was not compiling with the following error: > > rte_eth_pcap.c: In function 'rte_pmd_init_internals': > rte_eth_pcap.c:559:30: error: dereferencing pointer to incomplete type > rte_eth_pcap.c:560:15: error: dereferencing pointer to incomplete type > rte_eth_pcap.c:561:18: error: dereferencing pointer to incomplete type > rte_eth_pcap.c:603:47: error: dereferencing pointer to incomplete type > rte_eth_pcap.c: In function 'rte_pmd_pcap_init': > rte_eth_pcap.c:732:73: error: 'dict' undeclared (first use in this > function) > rte_eth_pcap.c:732:73: note: each undeclared identifier is reported > only once for each function it appears in > > This commit replaces "struct args_dict" by "struct rte_kvargs" to fix > the compilation issue. > > By the way, it also removes the declaration of these functions from > the header file as no other file in DPDK references one of them. It > avoids to include in rte_eth_pcap.h. > > Pointed-out-by: Meir Tseitlin > Signed-off-by: Olivier Matz I missed it when applying the patches. Sorry for the inconvenience. It's now acked and applied. -- Thomas