From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] Don't inline string functions Date: Wed, 14 May 2014 17:47:01 +0200 Message-ID: <1559974.KXN93MZ8m0@xps13> References: <20140514081932.37847146@nehalam.linuxnetplumber.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Stephen Hemminger Return-path: In-Reply-To: <20140514081932.37847146-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-05-14 08:19, Stephen Hemminger: > It makes no sense to inline string functions, in fact snprintf > can't be inlined because the function supports variable number of > arguments. > > Signed-off-by: Stephen Hemminger > > --- > Resend because of lack of response Please do not resend patches. I prefer a ping request in the original thread. By the way, you didn't take into account my first comments: http://dpdk.org/ml/archives/dev/2014-April/002028.html and I'm still waiting answers to these patches: http://dpdk.org/ml/archives/dev/2014-March/001673.html http://dpdk.org/ml/archives/dev/2014-March/001676.html PS: I was going to apply your patches with these fixes: add FILE argument to debug functions [Thomas: fix quota_watermark example] eal: dont inline string functions [Thomas: update includes] -- Thomas