From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v7 2/2] mbuf: implement generic format for
	sched field
Date: Wed, 16 Jan 2019 09:41:20 +0100
Message-ID: <1561068.4x49Scgd5h@xps>
References: <20181219154237.836-1-reshma.pattan@intel.com>
 <20181220121609.16314-2-reshma.pattan@intel.com>
 <20190115151151.5105b80e@shemminger-XPS-13-9360>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Stephen Hemminger <stephen@networkplumber.org>,
 Reshma Pattan <reshma.pattan@intel.com>, jerin.jacob@caviumnetworks.com,
 nikhil.rao@intel.com, olivier.matz@6wind.com, jasvinder.singh@intel.com,
 cristian.dumitrescu@intel.com, konstantin.ananyev@intel.com
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id D33A61150
 for <dev@dpdk.org>; Wed, 16 Jan 2019 09:41:23 +0100 (CET)
In-Reply-To: <20190115151151.5105b80e@shemminger-XPS-13-9360>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

16/01/2019 00:11, Stephen Hemminger:
> On Thu, 20 Dec 2018 12:16:09 +0000
> Reshma Pattan <reshma.pattan@intel.com> wrote:
> 
> >  void
> > -rte_sched_port_pkt_write(struct rte_mbuf *pkt,
> > -			 uint32_t subport, uint32_t pipe, uint32_t traffic_class,
> > +rte_sched_port_pkt_write(struct rte_sched_port *port,
> > +			 struct rte_mbuf *pkt,
> > +			 uint32_t subport, uint32_t pipe,
> > +			 uint32_t traffic_class,
> >  			 uint32_t queue, enum rte_meter_color color)
> 
> Sorry I didn't notice this earlier, but changing the function signature like
> this is a complete ABI breakage.  Old code will be passing different arguments than
> new code; therefore this change breaks both source and binary compatibility.
> 
> Is 19.02 supposed to be an ABI/API breaking release? Or only an incremental update.

It is an API breaking release.