From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ixgbe: Fix an unnecessary check in vf rss Date: Tue, 27 Jan 2015 13:12:39 +0100 Message-ID: <1561845.4QtzaTeLCI@xps13> References: <1421811523-18737-1-git-send-email-changchun.ouyang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Ouyang Changchun Return-path: In-Reply-To: <1421811523-18737-1-git-send-email-changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > To follow up the comments from Wodkowski, PawelX, remove this unnecessary check, > as check_mq_mode has already check the queue number in device configure stage, > if the queue number of vf is not correct, it will return error code and exit, > so it doesn't need check again here in device start stage(note: pf_host_configure > is called in device start stage). > > This fixes commit 42d2f78abcb77ecb769be4149df550308169ef0f > > Signed-off-by: Changchun Ouyang Suggested-by: Pawel Wodkowski Fixes: 42d2f78abcb77 ("configure VF RSS") Applied Changchun, as you are working on ixgbe, maybe you would like to review some ixgbe patches from others? Thanks -- Thomas