From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Raz Amir" <razamir22-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: Crash related to virtio NICs in DPDK 2.0.0 on
	Freebsd 10.1 VM
Date: Mon, 13 Apr 2015 14:54:08 +0300
Message-ID: <156201d075e0$8d5e8390$a81b8ab0$@gmail.com>
References: <13b901d07149$4e20d430$ea627c90$@gmail.com>
 <145601d07214$20aa04b0$61fe0e10$@gmail.com> <19871442.I62j3xGbVC@xps13>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: "'Thomas Monjalon'" <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <19871442.I62j3xGbVC@xps13>
Content-Language: en-gb
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Thanks. I will submit a patch

-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] 
Sent: 13 April 2015 13:46
To: Raz Amir
Cc: dev-VfR2kkLFssw@public.gmane.org; david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org
Subject: Re: Crash related to virtio NICs in DPDK 2.0.0 on Freebsd 10.1 VM

2015-04-08 18:53, Raz Amir:
> The issues happens also in dpdk 1.8.0, and related to patch 
> http://dpdk.org/dev/patchwork/patch/239/
> 
> Adding Thomas and David to the thread and I will appreciate your input.
> 
> The patch comes to solve a file descriptor leak in the bsdapp version 
> of rte_eal_iopl_init after opening the /dev/io device.
> 
> Seems like this isn't a file descriptor leak, and it should remain 
> open - as I wrote below, I am using virtio.

Thanks for the bug report.
It seems there was no validation for FreeBSD with virtio.

> After removing it and testing the crash was resolved.
> 
> Any objection for removing the close(fd) that was added at dpdk 1.8.0?

No, there was a doubt because the man page was not clear.
	http://www.freebsd.org/cgi/man.cgi?query=io&sektion=4

In case you submit a patch, please add this line:
Fixes: 8a312224bcde ("eal/bsd: fix fd leak")

> Are there scenarios that might be impacted by removing it?

I don't think so.

Thanks