From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-stable] [PATCH v3] kni: fix build with gcc 8.1
Date: Wed, 27 Jun 2018 15:15:11 +0200
Message-ID: <1562187.JQU0VIWQ63@xps>
References: <07e4d536-edd6-292d-5adb-c05793731623@intel.com>
 <20180626113807.67100-1-ferruh.yigit@intel.com>
 <E115CCD9D858EF4F90C690B0DCB4D8977F8DC763@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: stable@dpdk.org, "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>,
 "stephen@networkplumber.org" <stephen@networkplumber.org>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8977F8DC763@IRSMSX108.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

26/06/2018 15:43, De Lara Guarch, Pablo:
>=20
> > Error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option is
> > enabled.
> >=20
> > build error:
> > In function =E2=80=98strncpy=E2=80=99,
> >     inlined from =E2=80=98igb_get_drvinfo=E2=80=99 at
> >     .../dpdk/build/build/kernel/linux/kni/igb_ethtool.c:814:2:
> >     .../include/linux/string.h:246:9: error: =E2=80=98__builtin_strncpy=
=E2=80=99 output
> >     may be truncated copying 31 bytes from a string of length 42
> >     [-Werror=3Dstringop-truncation]
> >       return __builtin_strncpy(p, q, size);
> >                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >=20
> > Fixed by using strlcpy instead of strncpy.
> >=20
> > adapter->fw_version size kept same because of
> > c3698192940c ("kni: fix build with gcc 7.1")
> >=20
> > Also next line strncpy usage replaced with strlcpy while arround.
> >=20
> > Fixes: c3698192940c ("kni: fix build with gcc 7.1")
> > Cc: stable@dpdk.org
> >=20
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>=20
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied, thanks