From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] config: remove useless lines for DPAA2
Date: Wed, 04 Apr 2018 00:04:10 +0200
Message-ID: <1563071.oSqjFj96SH@xps>
References: <20180402220649.662-1-thomas@monjalon.net>
 <3161325.7B0DNJKXUk@xps> <482ae28a-ef73-9bde-ae06-f9983aa2caec@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, hemant.agrawal@nxp.com
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 9930E1B86C
 for <dev@dpdk.org>; Wed,  4 Apr 2018 00:04:12 +0200 (CEST)
In-Reply-To: <482ae28a-ef73-9bde-ae06-f9983aa2caec@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

03/04/2018 11:43, Shreyansh Jain:
> On Tuesday 03 April 2018 12:33 PM, Thomas Monjalon wrote:
> > 03/04/2018 08:55, Shreyansh Jain:
> >> On Tuesday 03 April 2018 03:36 AM, Thomas Monjalon wrote:
> >>> Some comments are not relevant in a config which only overrides
> >>> the default config.
> >>>
> >>> The option CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER is already disabled
> >>> by default so it can be removed from this file.
> >>>
> >>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >>> ---
> >>>    config/defconfig_arm64-dpaa2-linuxapp-gcc | 7 -------
> >>>    1 file changed, 7 deletions(-)
> >>
> >> I think DEBUG_DRIVER should exist in local config so that a developer
> >> can easily toggle it without modifying the common_base, which should
> >> serves as repository rather than toggle.
> > 
> > No, the file to be modified is .config in the build directory,
> > not the default config.
> 
> In my environment I prefer changing the platform config rather than 
> local .config as that way I can track changes through git.
> 
> > 
> >> I do see the problem that having an option in common_base and then
> >> having it again in local config without overriding (=n) - is non-intuitive.
> >>
> >> But, I still feel it is easier to control changes in local config -
> >> (make T=<local config>) is easily visible.
> > 
> > It is not a local config file.
> > The local config is .config.
> 
> Sorry, allow me to rephrase my previous wordings:
> 
> s/local config/platform config/
> 
> Anyways, this is just my personal preference - not a big inconvenience.
> Thanks for the patch.
> 
> Acked-By: Shreyansh Jain <shreyansh.jain@nxp.com>

Applied