From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] kni: convert license headers to SPDX tags Date: Thu, 11 Jan 2018 18:54:23 +0100 Message-ID: <1566328.PjHp2kMIxd@xps> References: <20171219000519.53666-1-ferruh.yigit@intel.com> <1b245a10-1af9-ebca-021c-63680f4e1cc6@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Hemant Agrawal To: Ferruh Yigit Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 37E492D13 for ; Thu, 11 Jan 2018 18:54:52 +0100 (CET) In-Reply-To: <1b245a10-1af9-ebca-021c-63680f4e1cc6@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/01/2018 07:46, Hemant Agrawal: > On 1/9/2018 9:00 PM, Ferruh Yigit wrote: > > On 1/9/2018 3:24 PM, Thomas Monjalon wrote: > >> 09/01/2018 16:12, Ferruh Yigit: > >>> --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h > >>> +++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h > >>> +/* SPDX-License-Identifier: (BSD-3-Clause OR LGPL-2.1) */ > >>> +/* > >>> + * Copyright(c) 2007-2014 Intel Corporation. > >>> */ > >> > >>> --- a/lib/librte_eal/linuxapp/kni/kni_net.c > >>> +++ b/lib/librte_eal/linuxapp/kni/kni_net.c > >>> +// SPDX-License-Identifier: GPL-2.0 > >>> +/* > >>> + * Copyright(c) 2010-2014 Intel Corporation. > >>> */ > >> > >> Why these empty lines between SPDX and Copyright? > > > > For kernel module files I followed Linux style, as "//" comments in .c files. > > I don't have strong opinion about this... > > > > > I think it is just fine to use the Linux style for kernel module based > code. > Acked-by: Hemant Agrawal Applied, thanks