From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v1 1/2] crypto/aesni_mb: support IPsec
	MUlti-buffer lib v0.49
Date: Sat, 31 Mar 2018 15:40:02 +0200
Message-ID: <1567480.ON0PbBP0xs@xps>
References: <20180327121430.44541-1-marko.kovacevic@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com
To: "Kovacevic, Marko" <marko.kovacevic@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 5A7101322C
 for <dev@dpdk.org>; Mon,  2 Apr 2018 16:52:12 +0200 (CEST)
In-Reply-To: <20180327121430.44541-1-marko.kovacevic@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

27/03/2018 14:14, Kovacevic, Marko:
> From: Marko Kovacevic <marko.kovacevic@intel.com>
> 
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>

No comment at all?
This new version doesn't work with the env variable.
It is probably worth few words.

> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -183,8 +183,6 @@ config () # <directory> <target> <options>
>  		test -z "$ARMV8_CRYPTO_LIB_PATH" || \
>  		sed -ri   's,(PMD_ARMV8_CRYPTO=)n,\1y,' $1/.config
>  		test -z "$AESNI_MULTI_BUFFER_LIB_PATH" || \
> -		sed -ri       's,(PMD_AESNI_MB=)n,\1y,' $1/.config
> -		test -z "$AESNI_MULTI_BUFFER_LIB_PATH" || \
>  		sed -ri      's,(PMD_AESNI_GCM=)n,\1y,' $1/.config

The purpose of test-build.sh is to test the build :)
So you need to provide a way to enable this PMD if the dependency
is available. Look at DPDK_DEP_SSL as an example.