From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-stable] [PATCH] test: fix build when pdump
	config is disabled
Date: Wed, 27 Mar 2019 01:08:58 +0100
Message-ID: <1568544.Edi8VMo79k@xps>
References: <20190320113319.26134-1-reshma.pattan@intel.com>
 <CAHLOa7QJrPCyp6mJAhLaMQF21pT86YTjbpVe8J8fzvJUHzb=kg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: stable@dpdk.org, Rami Rosen <ramirose@gmail.com>, dev <dev@dpdk.org>,
 "Rosen, Rami" <rami.rosen@intel.com>, bruce.richardson@intel.com
To: Reshma Pattan <reshma.pattan@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <CAHLOa7QJrPCyp6mJAhLaMQF21pT86YTjbpVe8J8fzvJUHzb=kg@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

20/03/2019 16:17, Rami Rosen:
> pdump unit test has dependency on pthread code
> in test.c and process.h to run send_pkts(),
> this code should be enabled only when
> CONFIG_RTE_LIBRTE_PDUMP is enabled.
> 
> Bugzilla ID: 222
> 
> Fixes: 086eb64db3 ("test/pdump: add unit test for pdump library")
> CC: stable@dpdk.org
> 
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> 
> +1
> 
> Checked when CONFIG_RTE_LIBRTE_PDUMP=n
> with latest code from master, build completes succesfully
> 
> Reviewed-by: Rami Rosen <ramirose@gmail.com>

Applied, thanks

Note that such #ifdef will be removed when the "make build system"
will be removed from DPDK (far target).