From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] event/dsw: avoid supplying
	-Wno-format-nonliteral to icc
Date: Thu, 04 Oct 2018 18:30:50 +0200
Message-ID: <1568909.fdk1z5rJxs@xps>
References: <20181003081353.6679-1-mattias.ronnblom@ericsson.com>
 <37910565-67d7-ff1e-aaea-65418be890a7@intel.com> <2641514.GnYxfkIzXT@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
To: Mattias =?ISO-8859-1?Q?R=F6nnblom?= <mattias.ronnblom@ericsson.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 41E5D1B505
 for <dev@dpdk.org>; Thu,  4 Oct 2018 18:30:54 +0200 (CEST)
In-Reply-To: <2641514.GnYxfkIzXT@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

04/10/2018 18:09, Thomas Monjalon:
> 03/10/2018 21:18, Ferruh Yigit:
> > On 10/3/2018 9:13 AM, Mattias R=F6nnblom wrote:
> > > Make the -Wno-format-nonliteral flag conditional, and only set in
> > > clang and gcc builds, since this flag is not supported (nor needed)
> > > when building with icc.
> > >=20
> > > Signed-off-by: Mattias R=F6nnblom <mattias.ronnblom@ericsson.com>
> >=20
> > perhaps simply: "event/dsw: fix icc build"
> >=20
> > Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build syst=
em")
> >=20
> > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>=20
> Applied, thanks

Cancelled as a v2 was applied in next-event tree.

Advices to avoid such confusion:
	- the v1 must be marked as superseded in patchwork
	- the v2 must be in the same thread thanks to --in-reply-to

And thanks Ferruh for spotting this :)