From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [RFC PATCH] mk: symlink every headers first Date: Wed, 21 Jun 2017 12:41:42 +0200 Message-ID: <1569330.jjeHmIoRYc@xps> References: <20170620212139.9508-1-thomas@monjalon.net> <20170621102702.GA93468@bricha3-MOBL3.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: gaetan.rivet@6wind.com, dev@dpdk.org To: Bruce Richardson Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id AA5D65583 for ; Wed, 21 Jun 2017 12:41:43 +0200 (CEST) In-Reply-To: <20170621102702.GA93468@bricha3-MOBL3.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/06/2017 12:27, Bruce Richardson: > On Tue, Jun 20, 2017 at 11:21:39PM +0200, Thomas Monjalon wrote: > > If a library or a build tool uses a definition from a driver, > > there is a build ordering issue, like seen when moving PCI code > > into a bus driver. > > > > One option is to keep PCI helpers and some common definitions in EAL. > > The other option is to symlink every headers at the beginning of > > the build so they can be included by any other component. > > > > This patch shows how to achieve the second option. > > > > Signed-off-by: Thomas Monjalon > > --- > > My 2c. > > This may be worth doing, however, two points to consider. > > 1. If we look to change build system this may not be worth doing unless > a compelling need becomes obvious in the short term. In the meantime, > for cases where it is needed... > 2. libraries can already access the includes from drivers or other > places fairly easily, just by adding the relevant "-I" flag to the > CFLAGS for that lib. You mean adding a -I pointing to source location instead of the build directory? > That said, since the work is already done developing this, and if it > doesn't hurt in terms of build time, I suppose we might as well merge > it in. It hurts a bit the build time. > So tentative ack from me, subject to testing and feedback from others. I would prefer not applying this patch if Gaetan can organize EAL and bus drivers in a way that everything compile fine. Libraries should not look into drivers.