From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org,
Kishore Padmanabha <kishore.padmanabha@broadcom.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: Re: [PATCH 2/2] net/bnxt: fix shadow variable warnings
Date: Tue, 17 Mar 2026 09:02:45 +0100 [thread overview]
Message-ID: <15698507.tv2OnDr8pf@thomas> (raw)
In-Reply-To: <20260312002123.867357-3-stephen@networkplumber.org>
12/03/2026 01:20, Stephen Hemminger:
> Fix things flagged as warnings about shadowed variables.
> If the variable was harmless overlap then just drop the shadowed
> version. For min values case use RTE_MIN3() and RTE_MIN4().
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/bnxt/bnxt.h | 6 +++---
> drivers/net/bnxt/bnxt_ethdev.c | 3 +--
> drivers/net/bnxt/bnxt_rxq.c | 6 ++----
> drivers/net/bnxt/bnxt_txr.c | 3 ---
> 4 files changed, 6 insertions(+), 12 deletions(-)
Why not removing cflags += no_shadow_cflag ?
next prev parent reply other threads:[~2026-03-17 8:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 0:20 [PATCH 0/2] net/bnxt: shadow variable warnings Stephen Hemminger
2026-03-12 0:20 ` [PATCH 1/2] eal: add RTE_MIN4 and RTE_MAX4 macros Stephen Hemminger
2026-03-12 0:20 ` [PATCH 2/2] net/bnxt: fix shadow variable warnings Stephen Hemminger
2026-03-12 22:46 ` Kishore Padmanabha
2026-03-17 8:02 ` Thomas Monjalon [this message]
2026-03-18 3:16 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15698507.tv2OnDr8pf@thomas \
--to=thomas@monjalon.net \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=kishore.padmanabha@broadcom.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox