Re: [PATCH 2/2] net/bnxt: fix shadow variable warnings

Stephen Hemminger
2026-03-18T03:16:23Z

On Tue, 17 Mar 2026 09:02:45 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:

> 12/03/2026 01:20, Stephen Hemminger:
> > Fix things flagged as warnings about shadowed variables.
> > If the variable was harmless overlap then just drop the shadowed
> > version. For min values case use RTE_MIN3() and RTE_MIN4().
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > drivers/net/bnxt/bnxt.h | 6 +++---
> > drivers/net/bnxt/bnxt_ethdev.c | 3 +--
> > drivers/net/bnxt/bnxt_rxq.c | 6 ++----
> > drivers/net/bnxt/bnxt_txr.c | 3 ---
> > 4 files changed, 6 insertions(+), 12 deletions(-)
>
> Why not removing cflags += no_shadow_cflag ?
>
>

Yes, should do that, just wasn't on the tree I was testing.