Re: [PATCH 2/2] net/bnxt: fix shadow variable warnings

Thomas Monjalon
2026-03-17T08:02:53Z

12/03/2026 01:20, Stephen Hemminger:
> Fix things flagged as warnings about shadowed variables.
> If the variable was harmless overlap then just drop the shadowed
> version. For min values case use RTE_MIN3() and RTE_MIN4().
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/bnxt/bnxt.h | 6 +++---
> drivers/net/bnxt/bnxt_ethdev.c | 3 +--
> drivers/net/bnxt/bnxt_rxq.c | 6 ++----
> drivers/net/bnxt/bnxt_txr.c | 3 ---
> 4 files changed, 6 insertions(+), 12 deletions(-)

Why not removing cflags += no_shadow_cflag ?