From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4 00/38] ice share code update. Date: Sun, 31 Mar 2019 19:06:03 +0200 Message-ID: <1570574.eaFxuQL18R@xps> References: <20190228055650.25237-1-qi.z.zhang@intel.com> <20190325054452.2616-1-qi.z.zhang@intel.com> <039ED4275CED7440929022BC67E7061153351DC4@SHSMSX103.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Lu, Wenzhuo" , "Yang, Qiming" , "Stillwell Jr, Paul M" , "Yigit, Ferruh" , cathal.ohare@intel.com, john.mcnamara@intel.com To: "Zhang, Qi Z" Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id AED3A11A4 for ; Sun, 31 Mar 2019 19:06:06 +0200 (CEST) In-Reply-To: <039ED4275CED7440929022BC67E7061153351DC4@SHSMSX103.ccr.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/03/2019 08:07, Zhang, Qi Z: > > Sync to latest kernel driver, main changes: > > 1. add DCB/FDIR support. > > 2. add more APIs in switch module. > > 3. code clean and bug fix. > > > > Qi Zhang (38): > > net/ice/base: add switch resource allocation and free > > net/ice/base: improve comments > > net/ice/base: add two helper functions > > net/ice/base: add helper macros > > net/ice/base: allow package copy to be used after resets > > net/ice/base: clean code > > net/ice/base: declare functions as external > > net/ice/base: add more APIs in switch module > > net/ice/base: add VSI queue context framework > > net/ice/base: add APIs to add remove ethertype filter > > net/ice/base: add APIs to get allocated resources > > net/ice/base: add APIs to alloc/free resource counter > > net/ice/base: add APIs to get VSI promiscuous mode > > net/ice/base: add MAC filter with marker and counter > > net/ice/base: add two helper functions for flow management > > net/ice/base: fix minor issues > > net/ice/base: update macros > > net/ice/base: clean code > > net/ice/base: enable VSI queue context > > net/ice/base: ensure only valid bits are set > > net/ice/base: enhance get link status command > > net/ice/base: add RSS key related macro and structures > > net/ice/base: do not write TCAM entries back > > net/ice/base: remove local VSIG allocations > > net/ice/base: fix minor issues > > net/ice/base: update copyright time > > net/ice/base: fix Klockwork analysis reported issues > > net/ice/base: return config error without queue to disable > > net/ice/base: add function to check FW recovery mode > > net/ice/base: change profile id reference counting > > net/ice/base: add DCB support > > net/ice/base: add FDIR support > > net/ice/base: change profile priority for RSS reply > > net/ice/base: fix duplicate resource allocations > > net/ice/base: fix minor issues > > net/ice/base: increase prototol offset size > > net/ice/base: revert the workaround for resource allocation > > net/ice/base: rework on bit ops > > Applied to dpdk-next-net-intel. > > Thanks > Qi 3 commits have the title "fix minor issues", that's a funny performance. When the ice PMD will enter in a serious phase, you should write some real commit titles and explain what are the fixed issues. For DPDK 19.05, I guess it's fine because ice PMD is not going to be really used soon, right?