From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id B61FBFF8864 for ; Fri, 1 May 2026 05:52:14 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 967B4402A9; Fri, 1 May 2026 07:52:13 +0200 (CEST) Received: from fout-b8-smtp.messagingengine.com (fout-b8-smtp.messagingengine.com [202.12.124.151]) by mails.dpdk.org (Postfix) with ESMTP id B95C040285; Fri, 1 May 2026 07:52:12 +0200 (CEST) Received: from phl-compute-09.internal (phl-compute-09.internal [10.202.2.49]) by mailfout.stl.internal (Postfix) with ESMTP id CCE801D000D0; Fri, 1 May 2026 01:52:11 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-09.internal (MEProxy); Fri, 01 May 2026 01:52:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1777614731; x=1777701131; bh=MHH7nc4i/NML6FWplY9JdsT8zeTwHi8VP5hgO9Z+vts=; b= snH0nZvveKqJXkoTQyTZWtbJkdJ1J2QKi/zPQYcIVj+q7ZOY/FLBv1Nm8/A/pbDJ /bEGn5GXWVrfv0kvdHGRNRmSRI8Pkk+P24/eT9JrhARrP3JEZ8pD+Jvx/0BOF6zm wfbLFR4xbg+nFDlasSHFNMSreFMgZIqTDU8ywD0MDHsZZgpjn+l6I4atRo/wprpT nmNaXaIGgmSZ4HnpSZKCntrWrg0N+REefzjdIgHaFQwQWdhQMkAlr8BE32RpvJMe /HXkmhYNHyE5ub5CX+YBI8qI7rsx1gfXWyiVj8ZEltjkmi2TMYNs6igIvLY193r1 WTA4EhwLIjKf4MsQ7B+krg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1777614731; x= 1777701131; bh=MHH7nc4i/NML6FWplY9JdsT8zeTwHi8VP5hgO9Z+vts=; b=p KXbS02jVj99GX41nDRg6gyQI0z0AvcFm4/p0EZM75daKaSpFQ3lQVK81bSKSa+X6 y4JB/OMiBBY8pjT43Kj7DzKACX1TpxV1UD2PezyA0hkgOP8iQqN9guXuBAJFyhMi +ar1BxnbOv+r9FYNzcxWctpeBNLBqMvL6upjLfdKz0HcbsOCqooUHE6gRIyYdaVj QLu3tJFwVjZGBqhC+LCRrM/wqRFEGAWTOY0dVDye28+Cc4zuu+SeM/qrm9gTzMFP qx8GCqvR9EAhBFoXcuxB3iad5K36fhScYG/0lLsLNwYjtcCfdliKDVAx2cKXnqNh THBqKf7w1YSe8m80X86oA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdekleegudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecuhfhrohhmpefvhhhomhgrshcu ofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuggftrf grthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeuveejffejgedtgeegkefgvdeu gfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgspghrtghpthhtohepiedpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtohepmhgrrhgrthdrkhhhrghlihhliheshhhurg ifvghirdgtohhmpdhrtghpthhtohepuggvvhesughpughkrdhorhhgpdhrtghpthhtohep shhtrggslhgvseguphgukhdrohhrghdprhgtphhtthhopegurghvihgurdhmrghrtghhrg hnugesrhgvughhrghtrdgtohhmpdhrtghpthhtohepsghruhgtvgdrrhhitghhrghrughs ohhnsehinhhtvghlrdgtohhmpdhrtghpthhtohephhgvmhgrnhhtrdgrghhrrgifrghlse hngihprdgtohhm X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 May 2026 01:52:10 -0400 (EDT) From: Thomas Monjalon To: Marat Khalili Cc: "dev@dpdk.org" , "stable@dpdk.org" , David Marchand , Bruce Richardson , Hemant Agrawal Subject: Re: [PATCH v2] devtools: fix SPDX tag check Date: Fri, 01 May 2026 07:52:09 +0200 Message-ID: <15732573.JCcGWNJJiE@thomas> In-Reply-To: References: <20260429130935.3681177-1-thomas@monjalon.net> <20260430131600.329636-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 30/04/2026 15:30, Marat Khalili: > > diff --git a/devtools/check-spdx-tag.sh b/devtools/check-spdx-tag.sh > > index 2390941c74..41fc1fe01d 100755 > > --- a/devtools/check-spdx-tag.sh > > +++ b/devtools/check-spdx-tag.sh > > @@ -39,10 +39,8 @@ check_spdx() { > > fi > > > > files_without_spdx=$(cat $tmpfile) > > - git grep -LE '(/\*|#|;|\.\.) *SPDX-License-Identifier: [A-Z(]' -- $no_license_list > $tmpfile > > - for file in $files_without_spdx ; do > > - sed -i "/^$file$/d" $tmpfile > > - done > > + git grep -LE '(/\*|#|;|\.\.) *SPDX-License-Identifier: [A-Z(]' -- $no_license_list | > > + grep -vF "$files_without_spdx" > $tmpfile > > > > warnings=$(($warnings + $(wc -l < $tmpfile))) > > $quiet || cat $tmpfile > > -- > > 2.53.0 > > Sorry for forgetting to mention it right away, some kind of sentinel or if > condition is needed if $files_without_spdx can be empty, don't know how > realistic it is in practice and whether other parts are ready to handle this > case. E.g. `files_without_spdx=$(echo //sentinel; cat $tmpfile)`. I hope it > won't make the whole thing too complicated and not worth it. Sorry I don't understand the need for a sentinel. The script is working fine with an empty files_without_spdx.