From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-stable] [PATCH v2] vdev: fix name comparison
	in find_vdev
Date: Wed, 28 Mar 2018 00:35:56 +0200
Message-ID: <1573463.hXvn9TCkJ5@xps>
References: <eb657634-cdf1-59be-2331-718933964f78@intel.com>
 <1520873640-24067-1-git-send-email-nprachan@vyatta.att-mail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: stable@dpdk.org, Jianfeng Tan <jianfeng.tan@intel.com>, dev@dpdk.org,
 jblunck@infradead.org
To: Nachiketa Prachanda <nprachan@vyatta.att-mail.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1520873640-24067-1-git-send-email-nprachan@vyatta.att-mail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

12/03/2018 17:54, Nachiketa Prachanda:
> Use strcmp to compare device names as the strncmp in original code
> causes find_vdev to return -EEXIST  for names that are prefix
> of another. The creation of interfaces fails unpredictably based
> on the order of their creation. An easy way hit this bug is to create
> eth_vhost1 after eth_vhost11.
> 
> Fixes: dda987315ca2 ("vdev: make virtual bus use its device struct")
> Cc: jblunck@infradead.org
> Cc: stable@dpdk.org
> 
> Signed-off-by: Nachiketa Prachanda <nprachan@vyatta.att-mail.com>
> Acked-by: Jianfeng Tan <jianfeng.tan@intel.com>

Applied, thanks