From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ip_frag: fix ipv6 when MTU sizes not aligned to 8 bytes Date: Wed, 19 Dec 2018 22:37:33 +0100 Message-ID: <1574497.3ne19FqZsX@xps> References: <20181127045613.16437-1-3chas3@gmail.com> <2601191342CEEE43887BDE71AB977258010D8BC664@IRSMSX106.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Ananyev, Konstantin" , Chas Williams <3chas3@gmail.com> To: Chas Williams Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E35E91B5AA for ; Wed, 19 Dec 2018 22:37:36 +0100 (CET) In-Reply-To: <2601191342CEEE43887BDE71AB977258010D8BC664@IRSMSX106.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > The same issue was fixed on for the ipv4 version of this routine in > > commit 8d4d3a4f7337 ("ip_frag: handle MTU sizes not aligned to 8 bytes"). > > Briefly, the size of an ipv6 header is always 40 bytes. With an MTU of > > 1500, this will never produce a multiple of 8 bytes for the frag_size > > and this routine can never succeed. Since RTE_ASSERTS are disabled by > > default, this failure is tpyically ignored. > > > > To fix this, round down to the nearest 8 bytes and use this when > > producing the fragments. > > > > Fixes: 0aa31d7a5929 ("ip_frag: add IPv6 fragmentation support") > > > > Signed-off-by: Chas Williams > > Acked-by: Konstantin Ananyev Applied, thanks