From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2 11/17] librte_acl: add AVX2 as new
	rte_acl_classify() method
Date: Mon, 19 Jan 2015 18:22:40 +0100
Message-ID: <1576198.aXfb5MeZ7p@xps13>
References: <1421090181-17150-1-git-send-email-konstantin.ananyev@intel.com>
 <1421090181-17150-12-git-send-email-konstantin.ananyev@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Konstantin Ananyev <konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1421090181-17150-12-git-send-email-konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2015-01-12 19:16, Konstantin Ananyev:
> +/*
> + * Select highest avaialbe classify method as default one.

Typo here.
Actually, I've seen few typos when browsing your big patchset
but I don't remember exactly where.
Maybe that a tool like codespell could help.

[...]

> +	else if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_SSE4_1))
> +#else
>  	if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_SSE4_1))
> +#endif

Minor nit, it could be
+	else
+#endif
 	if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_SSE4_1))

-- 
Thomas