Re: [PATCH] ethdev: fix crash with multiprocess

[Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>]

2015-03-26 17:36, De Lara Guarch, Pablo:
> From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Bruce Richardson
> > The data structure for the rx and tx callbacks is local to each process
> > since it contains function pointers and cannot be shared between
> > different unique binaries. However, because it is not in
> > rte_eth_dev_data structure, the array is not getting initialized for
> > secondary processes - neither is it getting appropriately resized if the
> > number of RX/TX queues changes. This causes crashes in secondary
> > processes as they dereference a null pointer in struct rte_eth_dev.
> > 
> > This patch fixes this by introducing an upper-bound on the number of
> > queues per port that can be configured, and then uses this to make the
> > array statically sized, thereby avoiding the crashes.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> Tested-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Fixes: 4dc294158cac ("ethdev: support optional Rx and Tx callbacks")

Acked-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

Applied, thanks

The multiprocess design is difficult to maintain.
It would be better to have someone registered as maintainer of this part.