From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ethdev: fix crash with multiprocess Date: Fri, 27 Mar 2015 11:05:24 +0100 Message-ID: <1578031.OQmMz318h0@xps13> References: <1427389365-18631-1-git-send-email-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Richardson, Bruce" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-03-26 17:36, De Lara Guarch, Pablo: > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Bruce Richardson > > The data structure for the rx and tx callbacks is local to each process > > since it contains function pointers and cannot be shared between > > different unique binaries. However, because it is not in > > rte_eth_dev_data structure, the array is not getting initialized for > > secondary processes - neither is it getting appropriately resized if the > > number of RX/TX queues changes. This causes crashes in secondary > > processes as they dereference a null pointer in struct rte_eth_dev. > > > > This patch fixes this by introducing an upper-bound on the number of > > queues per port that can be configured, and then uses this to make the > > array statically sized, thereby avoiding the crashes. > > > > Signed-off-by: Bruce Richardson > > Tested-by: Pablo de Lara Fixes: 4dc294158cac ("ethdev: support optional Rx and Tx callbacks") Acked-by: Thomas Monjalon Applied, thanks The multiprocess design is difficult to maintain. It would be better to have someone registered as maintainer of this part.