From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 18/18] Change mk/rte.app.mk to add fm10k lib into link Date: Mon, 02 Feb 2015 00:39:27 -0800 (PST) Message-ID: <15810264.0ycXQc2BKH@xps13> References: <1422594454-11045-1-git-send-email-jing.d.chen@intel.com> <20150201005059.GC31443@localhost.localdomain> <4341B239C0EFF9468EE453F9E9F4604D016631DC@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Chen, Jing D" Return-path: In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D016631DC-E2R4CRU6q/6iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-02-02 08:10, Chen, Jing D: > From: Neil Horman [mailto:nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org] > > This patch should be merged with patch 17, and patch 2, and placed at the > > end of > > your series to avoid a FTBFS issue > > My rationale is to make every single patch not to break the compile. So, I'd like to > add the binary library into compile and link in last 2 patches, after all the actual code > are patched. For Patch 2, I think you are right, maybe a better way is to move it as > patch "16". > > But I'm not sure whether I should merge these 3 together. You know, somebody may > not happy to see the changes in different directory to appear in single patch. No, I think you are wrong. You can have modifications in different directories in a patch. A patch must be atomic (one addition/change/feature at a time) and buildable. In your case, it would be best to have a patch allowing compilation of fm10k after the patch for "register". So it would mean we are able to test the minimal driver and each feature added after. Thanks -- Thomas