From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Vlad Zolotarov <vladz-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v2 1/2] ixgbe: fix build with gcc 4.4
Date: Thu, 16 Apr 2015 02:18:44 -0700 (PDT) [thread overview]
Message-ID: <1581903.SRNWASATZe@xps13> (raw)
In-Reply-To: <552F7D85.2090002-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
2015-04-16 12:14, Vlad Zolotarov:
> On 04/15/15 23:49, Thomas Monjalon wrote:
> > The "may be used uninitialized" warning seems to be another GCC bug and is
> > workarounded with NULL initialization.
> > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> > @@ -1476,8 +1476,8 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts,
> > bool eop;
> > struct ixgbe_rx_entry *rxe;
> > struct ixgbe_rsc_entry *rsc_entry;
> > - struct ixgbe_rsc_entry *next_rsc_entry;
> > - struct ixgbe_rx_entry *next_rxe;
> > + struct ixgbe_rsc_entry *next_rsc_entry = NULL;
> > + struct ixgbe_rx_entry *next_rxe = NULL;
>
> -Wno-maybe-uninitialized ?
I prefer avoiding this flag for 2 reasons:
- It's not supported in every GCC versions (need special handling)
- NULL assigment doesn't hurt
next prev parent reply other threads:[~2015-04-16 9:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 9:31 [PATCH] ixgbe: fix build with gcc 4.4 Thomas Monjalon
[not found] ` <1429003900-20074-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-04-14 12:48 ` Vlad Zolotarov
[not found] ` <552D0CA2.9080905-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
2015-04-14 13:06 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB9772582141570C-pww93C2UFcwu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-04-14 13:38 ` Vlad Zolotarov
[not found] ` <552D1869.4060703-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
2015-04-14 14:17 ` Thomas Monjalon
2015-04-14 14:30 ` Vlad Zolotarov
[not found] ` <552D247D.9040204-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
2015-04-14 14:53 ` Thomas Monjalon
2015-04-14 15:17 ` Vlad Zolotarov
2015-04-14 14:59 ` Vlad Zolotarov
[not found] ` <552D2B59.9000907-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
2015-04-14 15:13 ` Thomas Monjalon
2015-04-14 15:21 ` Vlad Zolotarov
[not found] ` <552D308B.3010000-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
2015-04-14 15:28 ` Thomas Monjalon
2015-04-14 15:32 ` Vlad Zolotarov
2015-04-15 20:49 ` [PATCH v2 1/2] " Thomas Monjalon
[not found] ` <1429130956-17828-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-04-15 20:49 ` [PATCH v2 2/2] use simple zero initializers Thomas Monjalon
[not found] ` <1429130956-17828-2-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-04-16 10:12 ` Olivier MATZ
[not found] ` <552F8B09.9070000-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-04-16 12:55 ` Thomas Monjalon
2015-04-16 16:31 ` Mcnamara, John
2015-04-16 7:26 ` [PATCH v2 1/2] ixgbe: fix build with gcc 4.4 Zhang, Helin
2015-04-16 9:14 ` Vlad Zolotarov
[not found] ` <552F7D85.2090002-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
2015-04-16 9:18 ` Thomas Monjalon [this message]
2015-04-16 9:35 ` Vlad Zolotarov
2015-04-16 22:10 ` [PATCH v3 1/2] mk: fix build with gcc 4.4 and clang Thomas Monjalon
[not found] ` <1429222237-8002-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-04-16 22:10 ` [PATCH v3 2/2] use simple zero initializers Thomas Monjalon
[not found] ` <1429222237-8002-2-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-04-17 11:17 ` Mcnamara, John
2015-04-19 8:22 ` Vlad Zolotarov
[not found] ` <553365CD.5070407-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
2015-04-20 12:45 ` Thomas Monjalon
2015-04-17 11:15 ` [PATCH v3 1/2] mk: fix build with gcc 4.4 and clang Mcnamara, John
2015-04-19 8:21 ` Vlad Zolotarov
[not found] ` <553365A5.20405-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
2015-04-20 12:44 ` Thomas Monjalon
2015-04-14 12:51 ` [PATCH] ixgbe: fix build with gcc 4.4 Vlad Zolotarov
[not found] ` <552D0D65.6040500-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
2015-04-14 13:23 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB97725821415914-pww93C2UFcwu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-04-14 13:41 ` Vlad Zolotarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1581903.SRNWASATZe@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=vladz-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).