From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: false positive in check-symbol-change.sh tool
Date: Wed, 19 Sep 2018 19:43:57 +0200
Message-ID: <1582481.Q53MnriLgg@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Neil Horman <nhorman@tuxdriver.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id BC7817D4A
 for <dev@dpdk.org>; Wed, 19 Sep 2018 19:43:59 +0200 (CEST)
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Neil,

I think I've discovered a false positive with the script
devtools/check-symbol-change.sh
When checking the patch http://patches.dpdk.org/patch/40601/,
which is adding an experimental section with a symbol in it,
we can see this message:
ERROR: symbol rte_frag_table_del_expired_entries is added in a section other than the EXPERIMENTAL section of the version map

The code raising this error is below:
            if [ "$secname" != "EXPERIMENTAL" ]
            then
                # Symbols that are getting added in a section
                # other than the experimental section
                # to be moving from an already supported
                # section or its a violation
                grep -q \
                "$mname $symname [^EXPERIMENTAL] del" "$mapdb"
                if [ $? -ne 0 ]
                then
                    echo -n "ERROR: symbol $symname "
                    echo -n "is added in a section "
                    echo -n "other than the EXPERIMENTAL "
                    echo "section of the version map"
                    ret=1
                fi
            fi

After a quick check, I see two strange things:

1/ $secname is "+EXPERIMENTAL" in this case
This is probably the root cause of this false positive.

2/ The grep pattern is probably not what you want.
The regex [^EXPERIMENTAL] means "a character which is none
of the letters in EXPERIMENTAL".

Hope it can help you (or others) to fix some issues.
Thanks