From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH] build: mention -march in pkg-config description Date: Mon, 28 Jan 2019 01:50:56 +0100 Message-ID: <15834031.ur9EiTGk5p@xps> References: <20190110172806.12952-1-bluca@debian.org> <20190111095732.GA21328@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: stable@dpdk.org, Bruce Richardson , "Gavin Hu (Arm Technology China)" , "dev@dpdk.org" , "christian.ehrhardt@canonical.com" , Honnappa Nagarahalli , "jerinj@marvell.com" To: Luca Boccassi Return-path: In-Reply-To: <20190111095732.GA21328@bricha3-MOBL.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > Applications need to at least match DPDK's -march option to build > > > successfully due to some static inline functions in the public headers. > > > > > > This might cause problems, especially in distributions, so add a note > > > in the pkg-config description. > > > > > > Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja builds") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Luca Boccassi > > > --- > > > At the moment there are no adversely affected applications in Debian and > > > Ubuntu (collectd builds a separate shared object, and OVS/virtio-forwareder > > > are stand-alone DPDK-specific binaries), but we thought that having an > > > explicit notice would be good. > > > > > > --- a/meson.build > > > +++ b/meson.build > > > @@ -83,7 +83,9 @@ pkg.generate(name: meson.project_name(), > > > libraries: dpdk_libraries, > > > libraries_private: dpdk_drivers + dpdk_static_libraries + > > > ['-Wl,-Bdynamic'] + dpdk_extra_ldflags, > > > -description: 'The Data Plane Development Kit (DPDK)', > > > +description: '''The Data Plane Development Kit (DPDK). > > > +Note that CFLAGS might contain an -march flag higher than typical baseline. > > > +This is required for a number of static inline functions in the public > > From Arm's perspective, this notice is really necessary for some extensions like LSE to work for performance. > > Reviewed-by: Gavin Hu > > > No objection from me for more documentation. > > Acked-by: Bruce Richardson Applied, thanks