From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6 0/3] clean up interrupt handle Date: Wed, 05 Apr 2017 18:41:13 +0200 Message-ID: <1584304.2T3CYHfDvM@xps13> References: <20170404230459.15006-1-qi.z.zhang@intel.com> <20170404230908.15145-1-qi.z.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Qi Zhang Return-path: Received: from mail-wr0-f173.google.com (mail-wr0-f173.google.com [209.85.128.173]) by dpdk.org (Postfix) with ESMTP id 14A1037B3 for ; Wed, 5 Apr 2017 18:41:14 +0200 (CEST) Received: by mail-wr0-f173.google.com with SMTP id k6so22604164wre.2 for ; Wed, 05 Apr 2017 09:41:14 -0700 (PDT) In-Reply-To: <20170404230908.15145-1-qi.z.zhang@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-04-05 07:09, Qi Zhang: > It seems its not necessary to register an intr_handle for interrupt callback > function. "void* cb_arg" shows enough when be used to pass the object that > contain the information be required to handle the interrupt event( A typical > way which is implemented by almost all driver is by passing a rte_ethdev > instance). > The patch change the prototype of rte_intr_callback_fn by removing > the uncessary intr_handle paramter. Pasting some comments from previous versions: * You forgot to use --in-reply-to, so it is not convenient to check the history. * Please keep the the prior acked-by in your patches if there are. (if think there was a ack for vfio) * The test patch should be squashed with eal/drivers changes. New comment: * New drivers has been added, please rebase and update them.