From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] check-symbol-change: relax rule for identifying a section Date: Tue, 21 Aug 2018 11:03:21 +0200 Message-ID: <1584735.cRL6gNcrux@xps> References: <20180816110801.5378-1-nhorman@tuxdriver.com> <954d81fa-e977-ac7e-8c5f-fbe2fd186bf4@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Rao, Nikhil" To: Neil Horman Return-path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 044CA3DC for ; Tue, 21 Aug 2018 11:03:24 +0200 (CEST) In-Reply-To: <954d81fa-e977-ac7e-8c5f-fbe2fd186bf4@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/08/2018 05:03, Rao, Nikhil: > On 8/16/2018 4:38 PM, Neil Horman wrote: > > It was reported recently that some patches that add symbols to an > > existing EXPERIMENTAL section of a version map file generate errors > > because the check-symbol-change script was identifying the section as > > "@@" rather than EXPERIMENTAL. This was fairly clearly due to the fact > > that the rule identifying the version section expected the whole section > > to be added, rather than having it already exist, with only new symbols > > being added to the existing section. This led the match rule to misread > > the format of that line and pull the wrong word out of it. > > > > The fix is to relax the rule slightly. Rather than assume that the > > section must exist on a line that was added, allow the section name to > > be set by any line that ends in a '{', which should be correct, given > > our coding practices. The section name is then extracted as the next to > > the last word on the line ( $(NF-1) ). > > > > Tested by the reporter with good results > > > > Reported-by: nikhil.rao@intel.com > > Signed-off-by: Neil Horman > > > Tested-by: Nikhil Rao Applied, thanks