From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] net/softnic: add support for service cores
Date: Thu, 10 Jan 2019 00:33:49 +0100
Message-ID: <1586050.tAD3Vr9LNU@xps>
References: <20190103160432.147027-1-cristian.dumitrescu@intel.com>
 <3EB4FA525960D640B5BDFFD6A3D891268E826F2A@IRSMSX108.ger.corp.intel.com>
 <2914445.tvFdG4jiG5@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, "Singh, Jasvinder" <jasvinder.singh@intel.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A2C351B5A9
 for <dev@dpdk.org>; Thu, 10 Jan 2019 00:33:51 +0100 (CET)
In-Reply-To: <2914445.tvFdG4jiG5@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

10/01/2019 00:23, Thomas Monjalon:
> 07/01/2019 17:50, Dumitrescu, Cristian:
> >=20
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Cristian Dumitre=
scu
> > > Sent: Thursday, January 3, 2019 4:05 PM
> > > To: dev@dpdk.org
> > > Cc: Singh, Jasvinder <jasvinder.singh@intel.com>
> > > Subject: [dpdk-dev] [PATCH] net/softnic: add support for service cores
> > >=20
> > > Add support to run the Soft NIC device on service cores, based on the
> > > value of the sc parameter:
> > >=20
> > > 0: The current Soft NIC device is run explicitly by the application. =
The
> > >    firmware creates one or several pipelines for this dev and maps th=
em
> > >    to CPU cores that should not be service cores. The app is required=
 to
> > >    call rte_pmd_softnic_run() to make this dev work.
> > >=20
> > > 1 (default): The current device is run on the service cores transpare=
ntly
> > >    to the app. The firmware creates one or several pipelines for this=
 dev
> > >    current device and maps them to CPU cores that should be service c=
ores.
> > >    Each of these service cores is calling rte_pmd_softnic_run()
> > >    in order to make this dev work with no app intervention.
> > >=20
> > > Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > > ---
> >=20
> > Applied to next-qos tree, thanks!
>=20
> It does not compile with 32-bit toolchain:
>=20
> drivers/net/softnic/rte_eth_softnic_thread.c:140:28: error:
> cast between incompatible function types
> from =E2=80=98int (*)(uint16_t)=E2=80=99 {aka =E2=80=98int (*)(short unsi=
gned int)=E2=80=99}
> to =E2=80=98int32_t (*)(void *)=E2=80=99 {aka =E2=80=98int (*)(void *)=E2=
=80=99}
>   service_params.callback =3D (rte_service_func)rte_pmd_softnic_run;
>                             ^
>=20
> Fixing in-tree.

After a better look, I won't fix it myself because the simple fix
would be an API change.
It is removed from the pull in master for now, sorry.