From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4] eal: Support running as unprivileged user Date: Thu, 09 Mar 2017 17:11:24 +0100 Message-ID: <1586546.FPT1ddaDYK@xps13> References: <20170131174054.15324-1-benjamin.walker@intel.com> <20170131174453.15796-1-benjamin.walker@intel.com> <20170217112832.1099e809@plumbers-lap.home.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Ben Walker To: Stephen Hemminger Return-path: Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by dpdk.org (Postfix) with ESMTP id 3AB46234 for ; Thu, 9 Mar 2017 17:11:26 +0100 (CET) Received: by mail-wr0-f171.google.com with SMTP id l37so48288761wrc.1 for ; Thu, 09 Mar 2017 08:11:26 -0800 (PST) In-Reply-To: <20170217112832.1099e809@plumbers-lap.home.lan> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-02-17 11:28, Stephen Hemminger: > On Tue, 31 Jan 2017 10:44:53 -0700 > Ben Walker wrote: > > > + if (physaddr == RTE_BAD_PHYS_ADDR) { > > RTE_LOG(ERR, EAL, > > - "Cannot open /proc/self/pagemap: %s. " > > - "virt2phys address translation will not work\n", > > + "Cannot obtain physical addresses: %s. " > > + "Only vfio will function.\n", > > Please don't split a single error message across multiple lines. It makes > it harder for user to find the source code lines with simple grep. > Better to just have one long line for format string, or better yet be less wordy. > > Yes, the existing DPDK code has lots of these issues. You're right. Here the split is acceptable as there is strerror(errno) in the middle.