From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 1/2] app/testpmd: add a generic way for
	dumping packets
Date: Wed, 12 Sep 2018 17:00:34 +0200
Message-ID: <1587053.xzp1NJBhG1@xps>
References: <1536739583-29166-1-git-send-email-rasland@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: jingjing.wu@intel.com, dev@dpdk.org, shahafs@mellanox.com,
 xuemingl@mellanox.com
To: Raslan Darawsheh <rasland@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 43FCF4C9F
 for <dev@dpdk.org>; Wed, 12 Sep 2018 17:00:28 +0200 (CEST)
In-Reply-To: <1536739583-29166-1-git-send-email-rasland@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

12/09/2018 10:06, Raslan Darawsheh:
> verbosity for the received/sent packets is needed in all of the
> forwarding engines so moving it to be in a separate function.
> 
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> ---
>  app/test-pmd/Makefile  |   1 +
>  app/test-pmd/testpmd.h |   2 +
>  app/test-pmd/util.c    | 143 +++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 146 insertions(+)

If you are moving code from app/test-pmd/rxonly.c, you should
update this file in the same patch, so it will appear more clearly as a move.
Then the second patch would be only about adding the feature to more engines.