From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 10/16] Added support for selecting VFIO interrupt type from EAL command-line Date: Thu, 22 May 2014 14:34:33 +0200 Message-ID: <1589072.KAuytnYNqt@xps13> References: <1400514709-24087-11-git-send-email-anatoly.burakov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Anatoly Burakov Return-path: In-Reply-To: <1400514709-24087-11-git-send-email-anatoly.burakov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-05-19 16:51, Anatoly Burakov: > Unlike igb_uio, VFIO interrupt type is not set by kernel module > parameters but is set up via ioctl() calls at runtime. This warrants > a new EAL command-line parameter. It will have no effect if VFIO is > not compiled, but will set VFIO interrupt type to either "legacy" or > "msix" if VFIO support is compiled. Note that VFIO initialization will > fail if the interrupt type selected is not supported by the system. > > Signed-off-by: Anatoly Burakov > + } > else if (!strcmp(lgopts[option_index].name, OPT_CREATE_UIO_DEV)) another code style issue reported by checkpatch.pl ;) But it should be fixed by removing this code as Stephen suggests. -- Thomas