From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH] devtools: don't use bash extension in checkpatches Date: Sat, 15 Sep 2018 22:37:49 +0200 Message-ID: <1591958.AmeY3D3653@xps> References: <6831653.AvvoQPlBBt@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Ilya Maximets , dev@dpdk.org, Stephen Hemminger To: Arnon Warshavsky Return-path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 9C7FF2BE5 for ; Sat, 15 Sep 2018 22:37:54 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/09/2018 21:07, Arnon Warshavsky: > > > If we wish to keep the awk code in this file and not in a separate file, > > > maybe receiving the awk script parameters from the function > > > check_forbidden_additions( ) can also preserve the ability to reuse in > > > future cases. > > > > Yes I feel we could add some parameters to this function. > > And yes, we could move the awk script in a separate file. > > Actually, it would be better to keep checkpatches.sh as a wrapper script > > calling various tools. > > > I was under the wrong impression the opposite was desired, so yes, > moving the entire awk code to a separate file would indeed be the cleanest. OK, who can do this change please?