From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] E1000: fix for forced speed/duplex config Date: Mon, 07 Nov 2016 16:07:58 +0100 Message-ID: <15921137.Y6goMQDZAC@xps13> References: <1478129815-241504-1-git-send-email-ananda@versa-networks.com> <6A0DE07E22DDAD4C9103DF62FEBC090939340B93@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Lu, Wenzhuo" To: Ananda Sathyanarayana Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id D1FD02A5E for ; Mon, 7 Nov 2016 16:08:00 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id p190so188789495wmp.1 for ; Mon, 07 Nov 2016 07:08:00 -0800 (PST) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC090939340B93@shsmsx102.ccr.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > From the code, it looks like, hw->mac.autoneg, variable is used to switch > > between calling either autoneg function or forcing speed/duplex function. But > > this variable is not modified in eth_em_start/eth_igb_start routines (it is always > > set to 1) even while forcing the link speed. > > > > Following discussion thread has some more information on this > > > > http://dpdk.org/ml/archives/dev/2016-October/049272.html > > > > Signed-off-by: Ananda Sathyanarayana > Acked-by: Wenzhuo Lu Applied, thanks