From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH v2 1/2] mk: fix cross build errors Date: Tue, 29 May 2018 21:53:30 +0200 Message-ID: <1593317.cps1H5Vuk1@xps> References: <1527133127-29407-1-git-send-email-gavin.hu@arm.com> <20180529150008.GA25480@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Bruce Richardson , "dev@dpdk.org" To: Gavin Hu Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 161E0235 for ; Tue, 29 May 2018 21:53:33 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/05/2018 18:20, Gavin Hu: > > > -----Original Message----- > > From: Bruce Richardson > > Sent: Tuesday, May 29, 2018 11:00 PM > > To: Thomas Monjalon > > Cc: Gavin Hu ; dev@dpdk.org > > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2 1/2] mk: fix cross build > > errors > > > > On Tue, May 29, 2018 at 04:45:55PM +0200, Thomas Monjalon wrote: > > > 28/05/2018 15:24, Bruce Richardson: > > > > Would a simpler solution for this not be to put "-Wno-implicit- > > fallthrough" > > > > for pmdinfogen? GCC will not give a warning for an unrecognised "-Wno" > > > > flag when compiling, unless there are other errors. This means we > > > > can just use the flag without bothering with version checks. > > > > > > No, it does not work. > > > I have this error with clang 5.0.1: > > > error: unknown warning option '-Wno-format-truncation' > > > > > Yes, you still need to check for GCC to use the flag, just not for a specific > > version of GCC. > > > > /Bruce > Hi Thomas, did you meet this clang error when you applied my patch(which version?) or your own one? > @Bruce and Thomas, Could you review my v5 patch? Thanks! I've already replied to your v5. The error is seen with your v5.