From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] app/testpmd: Fix typos Date: Fri, 10 Mar 2017 14:14:08 +0100 Message-ID: <1593411.rPLBrTQPi8@xps13> References: <20170227192355.8317-1-ndas@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Mcnamara, John" To: Nirmoy Das Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 9A1F82C49 for ; Fri, 10 Mar 2017 14:14:10 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id t189so10327388wmt.1 for ; Fri, 10 Mar 2017 05:14:10 -0800 (PST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-02-28 17:20, Mcnamara, John: > > fixes trivial typos in app/test-pmd/cmdline.c, app/test-pmd/icmpecho.c, > > app/test-pmd/testpmd.c > > > > Signed-off-by: Nirmoy Das > > > Hi Nirmoy, > > Thanks for that. > > Just a small heads-up since this is your first patch. The subject line should > be lowercase (apart from known abbreviations) and there is no need to list > the files in the body since git will record that anyway. Have a look at > the contribution guidelines for some more pointers: > > http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-subject-line > > Apart from that, thanks for the patch. > > Acked-by: John McNamara Applied, thanks Nirmoy, we are looking for reviewers with a good english reading ;)