From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] vhost: add missing build dependency on librte_net Date: Thu, 18 Feb 2016 20:26:32 +0100 Message-ID: <1593893.DkKoCMf5f8@xps13> References: <20160218132549.GN21426@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Panu Matilainen Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id BA13BC3FC for ; Thu, 18 Feb 2016 20:28:06 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id c200so43950551wme.0 for ; Thu, 18 Feb 2016 11:28:06 -0800 (PST) In-Reply-To: <20160218132549.GN21426@yliu-dev.sh.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-02-18 21:25, Yuanhan Liu: > On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote: > > Commit d0cf91303d73 added dependency on librte_net headers to vhost > > but did not add this to the Makefile, which makes builds > > non-deterministic. Curiously it is non-parallel build that is > > consistently broken by this missing dependency, usually it's the other > > way around, but trying to build without -j(n) fails with: > > Yeah, I have confirmed it; I was wondering why I didn't meet such build > error. > > > > > dpdk/lib/librte_vhost/vhost_rxtx.c:41:20: > > fatal error: rte_ip.h: No such file or directory > > > > Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities") > > Signed-off-by: Panu Matilainen > > Acked-by: Yuanhan Liu Applied, thanks