From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] net/failsafe: fix for missing pclose after
	popen
Date: Thu, 03 Aug 2017 22:32:29 +0200
Message-ID: <1594412.gasu7JyoN7@xps>
References: <1501765798-14200-1-git-send-email-rasland@mellanox.com>
 <20170803135831.GG8124@bidouze.vm.6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: =?ISO-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>,
 rasland@mellanox.com
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 2A8412C16
 for <dev@dpdk.org>; Thu,  3 Aug 2017 22:32:32 +0200 (CEST)
In-Reply-To: <20170803135831.GG8124@bidouze.vm.6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

03/08/2017 15:58, Ga=EBtan Rivet:
> Hi Raslan,
>=20
> I sent a patch earlier regarding this but we will use yours.
> Two small nits below.
>=20
> On Thu, Aug 03, 2017 at 04:09:58PM +0300, rasland@mellanox.com wrote:
> > From: Raslan Darawsheh <rasland@mellanox.com>
> >=20
> > When there is no prefered device, failsafe will always
> > try to scan for prefered device. And if there is no device
> > found with the exec option, popen() will get an empty output.
> > In this case, it was forgotten to close the file descriptor.o
> > it is fixed by closing the file descriptor even if the output is emtpy.
> >=20
>=20
> Good job on finding the issue and fixing it.
> It has been assigned a coverity ID:
>=20
> Coverity issue: 158633
> > Fixes: a0194d82 ("net/failsafe: add flexible device definition")
> >=20
>=20
> The fixline should be 12-char long I think:
> Fixes: a0194d828100 ("net/failsafe: add flexible device definition")
>=20
> > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
>=20
> Otherwise:
>=20
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>

Applied, thanks