From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 0/3] timer: fix rte_timer_manage and improve unit tests Date: Mon, 27 Jul 2015 17:53:29 +0200 Message-ID: <1596194.uj9h7LeazE@xps13> References: <1437691347-58708-1-git-send-email-rsanford2@gmail.com> <4708068.jtpnxJe3Ir@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Sanford, Robert" Return-path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id A2980C594 for ; Mon, 27 Jul 2015 17:54:45 +0200 (CEST) Received: by wibxm9 with SMTP id xm9so123239982wib.1 for ; Mon, 27 Jul 2015 08:54:45 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-07-27 15:46, Sanford, Robert: > Hi Thomas, > > > Please, could you re-send this serie after having added the description > >of > > each patch in the commit messages? > > Yes, I will move the paragraphs that begin with "Patch n" from patch 0 to > their respective patches. > > > It seems you fix 2 bugs in the first patch. It may be clearer to split it > > in 2 patches with separate explanations. > > No, I respectfully disagree. The only bug that we address in patch 1 is > that the slaves become out of sync with the master. > The section that begins with "Description of rte_timer_manage() race > condition bug" is a general description to give background info for both > patches 2 and 3. I would like to leave that section in part 0, if it's OK > with you. OK perfect, thanks.