From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] e1000/base: fix the wrong assignment to msgbuf[0] Date: Tue, 14 Feb 2017 09:50:27 +0100 Message-ID: <1597373.SEVY7yqftY@xps13> References: <1487063647-16263-1-git-send-email-wang.yong19@zte.com.cn> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, wenzhuo.lu@intel.com To: Yong Wang Return-path: Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com [209.85.128.170]) by dpdk.org (Postfix) with ESMTP id 72B3F2C74 for ; Tue, 14 Feb 2017 09:50:29 +0100 (CET) Received: by mail-wr0-f170.google.com with SMTP id k90so164604613wrc.3 for ; Tue, 14 Feb 2017 00:50:29 -0800 (PST) In-Reply-To: <1487063647-16263-1-git-send-email-wang.yong19@zte.com.cn> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-02-14 04:14, Yong Wang: > In function e1000_update_mc_addr_list_vf(), "msgbuf[0]" is used prior > to initialization at "msgbuf[0] |= E1000_VF_SET_MULTICAST_OVERFLOW". > And "msgbuf[0]" is overwritten at "msgbuf[0] = E1000_VF_SET_MULTICAST". > Fix it by moving the second line prior to the first one that mentioned > above. > > Signed-off-by: Yong Wang Note about the title: msgbuf[0] does not explain anything in the title because we have no context when browsing the titles. It could be "e1000/base: fix multicast setting in VF".