From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] doc: document the new devargs syntax Date: Wed, 24 Jan 2018 17:51:36 +0100 Message-ID: <15984161.x0pdKaQmNl@xps> References: <1516114218-21501-1-git-send-email-yliu@fridaylinux.org> <20180123160816.uvsvegtltmzrr4yi@bidouze.vm.6wind.com> <20180124152432.GX29540@yliu-mob> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: =?ISO-8859-1?Q?Ga=EBtan?= Rivet , Ferruh Yigit , dev@dpdk.org To: Yuanhan Liu Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 51086160 for ; Wed, 24 Jan 2018 17:52:18 +0100 (CET) In-Reply-To: <20180124152432.GX29540@yliu-mob> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/01/2018 16:24, Yuanhan Liu: > On Tue, Jan 23, 2018 at 05:08:16PM +0100, Ga=EBtan Rivet wrote: > > Drivers answers to a specific API (ethdev, cryptodev, ...), to create > > standardized objects in response to parameters that are given to them > > for init. I think matching properties should be restricted to higher > > classes (bus, eth/crypto), >=20 > That's also what I thought. But I'm okay to have "driver" category > included for matching. I just don't really see a good example for that. >=20 > > while the driver class should be left > > free-form and to the responsibility of the PMD itself (while having the > > proper libraries for helping parsing safely, thus driving developpers > > toward similar syntaxes, while not forcing them in those). >=20 > I agree. The drv args are parsed by the drivers after all. It's hard to > have a good parser for all. I also don't know why we have to force them > to use "key=3Dvalue" pairs. >=20 > I even see some drawbacks from the forcement: >=20 > - some PMDs already use none key/value format. Forcing them breaks more. > If the "-w" "--vdev" compatibility is kept", nothing will be broken > from the user point of view. However, if "key=3Dvalue" pair is going to > be used, user have to do some changes. >=20 > - Some "value" might have to use the nested "=3D". Handling the nested pa= irs > introduces more complexity. >=20 > - sometimes, it's simple without an assignment. For example, it could be > "driver=3Dvhost-pmd,...,client" to let the vhost PMD acts as the client > mode. >=20 > Both Linux kernel and QEMU don't force the "key=3Dvalue" pair usage, I do= n't > see any good reason why we have to do that. OK