From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v7 1/2] cryptodev: API tidy and changes to support future extensions Date: Tue, 08 Mar 2016 15:10:32 +0100 Message-ID: <1600295.xLGLO1O6Fu@xps13> References: <1457116189-10226-1-git-send-email-fiona.trahe@intel.com> <1457351422-7617-2-git-send-email-fiona.trahe@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Fiona Trahe Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 0EC772C59 for ; Tue, 8 Mar 2016 15:12:11 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id n186so133497249wmn.1 for ; Tue, 08 Mar 2016 06:12:11 -0800 (PST) In-Reply-To: <1457351422-7617-2-git-send-email-fiona.trahe@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, 2016-03-07 11:50, Fiona Trahe: > This patch splits symmetric specific definitions and > functions away from the common crypto APIs to facilitate the future extension > and expansion of the cryptodev framework, in order to allow asymmetric > crypto operations to be introduced at a later date, as well as to clean the > logical structure of the public includes. The patch also introduces the _sym > prefix to symmetric specific structure and functions to improve clarity in > the API. It seems you need to update the examples in the same patch, they do not compile anymore after these changes. Again, it would be easier to review if you had split the changes to several patches: one for the sym suffix, others for more tidying.