dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v3 2/2] use simple zero initializers
Date: Mon, 20 Apr 2015 14:45:12 +0200	[thread overview]
Message-ID: <1602194.3mSZX90Ns8@xps13> (raw)
In-Reply-To: <553365CD.5070407-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>

> > To initialize a structure with zeros, one field was explicitly set
> > to avoid "missing initializer" bug with old GCC (e.g. 4.4).
> > This warning is now disabled (commit <insertlater>) for old versions of GCC,
> > so the workarounds may be removed.
> >
> > These initializers should not be needed for static variables but they
> > are still used to workaround an ICC bug (see commit b2595c4aa92d).
> >
> > There is one remaining exception where {0} initializer doesn't work cleanly,
> > even with recent GCC:
> > lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:735:9:
> > error: missing braces around initializer [-Werror=missing-braces]
> >    struct rte_mbuf mb_def = {0}; /* zeroed mbuf */
> >
> > Tested with gcc-4.4.7 (CentOS), gcc-4.7.2 (Debian), gcc-4.9.2 (Arch),
> > clang-3.6.0 and icc-13.1.1.
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> > Tested-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> > Tested-by: John McNamara <john.mcnamara-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> Acked-by: Vlad Zolotarov <vladz-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>

Applied, thanks

  parent reply	other threads:[~2015-04-20 12:45 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-14  9:31 [PATCH] ixgbe: fix build with gcc 4.4 Thomas Monjalon
     [not found] ` <1429003900-20074-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-04-14 12:48   ` Vlad Zolotarov
     [not found]     ` <552D0CA2.9080905-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
2015-04-14 13:06       ` Ananyev, Konstantin
     [not found]         ` <2601191342CEEE43887BDE71AB9772582141570C-pww93C2UFcwu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-04-14 13:38           ` Vlad Zolotarov
     [not found]             ` <552D1869.4060703-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
2015-04-14 14:17               ` Thomas Monjalon
2015-04-14 14:30                 ` Vlad Zolotarov
     [not found]                   ` <552D247D.9040204-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
2015-04-14 14:53                     ` Thomas Monjalon
2015-04-14 15:17                       ` Vlad Zolotarov
2015-04-14 14:59                 ` Vlad Zolotarov
     [not found]                   ` <552D2B59.9000907-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
2015-04-14 15:13                     ` Thomas Monjalon
2015-04-14 15:21                       ` Vlad Zolotarov
     [not found]                         ` <552D308B.3010000-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
2015-04-14 15:28                           ` Thomas Monjalon
2015-04-14 15:32                             ` Vlad Zolotarov
2015-04-15 20:49                             ` [PATCH v2 1/2] " Thomas Monjalon
     [not found]                               ` <1429130956-17828-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-04-15 20:49                                 ` [PATCH v2 2/2] use simple zero initializers Thomas Monjalon
     [not found]                                   ` <1429130956-17828-2-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-04-16 10:12                                     ` Olivier MATZ
     [not found]                                       ` <552F8B09.9070000-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-04-16 12:55                                         ` Thomas Monjalon
2015-04-16 16:31                                           ` Mcnamara, John
2015-04-16  7:26                                 ` [PATCH v2 1/2] ixgbe: fix build with gcc 4.4 Zhang, Helin
2015-04-16  9:14                                 ` Vlad Zolotarov
     [not found]                                   ` <552F7D85.2090002-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
2015-04-16  9:18                                     ` Thomas Monjalon
2015-04-16  9:35                                       ` Vlad Zolotarov
2015-04-16 22:10                                 ` [PATCH v3 1/2] mk: fix build with gcc 4.4 and clang Thomas Monjalon
     [not found]                                   ` <1429222237-8002-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-04-16 22:10                                     ` [PATCH v3 2/2] use simple zero initializers Thomas Monjalon
     [not found]                                       ` <1429222237-8002-2-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-04-17 11:17                                         ` Mcnamara, John
2015-04-19  8:22                                         ` Vlad Zolotarov
     [not found]                                           ` <553365CD.5070407-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
2015-04-20 12:45                                             ` Thomas Monjalon [this message]
2015-04-17 11:15                                     ` [PATCH v3 1/2] mk: fix build with gcc 4.4 and clang Mcnamara, John
2015-04-19  8:21                                     ` Vlad Zolotarov
     [not found]                                       ` <553365A5.20405-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
2015-04-20 12:44                                         ` Thomas Monjalon
2015-04-14 12:51   ` [PATCH] ixgbe: fix build with gcc 4.4 Vlad Zolotarov
     [not found]     ` <552D0D65.6040500-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
2015-04-14 13:23       ` Ananyev, Konstantin
     [not found]         ` <2601191342CEEE43887BDE71AB97725821415914-pww93C2UFcwu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-04-14 13:41           ` Vlad Zolotarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1602194.3mSZX90Ns8@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).