From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] l3fwd: Fix l3fwd crash due to unaligned load/store intrinsics Date: Mon, 07 Dec 2015 03:16:19 +0100 Message-ID: <1603158.UYlFNfLQMJ@xps13> References: <1447011596-2993-1-git-send-email-harish.patil@qlogic.com> <2601191342CEEE43887BDE71AB97725836AC87E4@irsmsx105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: harish.patil@qlogic.com Return-path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 397559404 for ; Mon, 7 Dec 2015 03:17:31 +0100 (CET) Received: by wmww144 with SMTP id w144so132003597wmw.0 for ; Sun, 06 Dec 2015 18:17:31 -0800 (PST) In-Reply-To: <2601191342CEEE43887BDE71AB97725836AC87E4@irsmsx105.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > l3fwd app expects PMDs to return packets whose L2 header is > > 16-byte aligned due to usage of _mm_load_si128()/_mm_store_si128() > > intrinsics in the app. However, most of the protocol stacks expects > > packets such that its IP/L3 header be aligned on a 16-byte boundary. > > > > Based on the recommendations received on dpdk-dev, we are changing > > the l3fwd app to use _mm_loadu_si128()/_mm_loadu_si128() so that the > > address need not be 16-byte aligned and thereby preventing crash. > > We have tested that there is no performance impact due to this > > change. > > > > Signed-off-by: Harish Patil > > Acked-by: Konstantin Ananyev Applied, thanks