From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,URIBL_SBL,URIBL_SBL_A autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00E81C433FF for ; Mon, 29 Jul 2019 12:20:35 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 80ADB206B8 for ; Mon, 29 Jul 2019 12:20:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="WZwF1S3M"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="k4U/UInG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80ADB206B8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7565E1BFAB; Mon, 29 Jul 2019 14:17:02 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 0E0861BF59 for ; Mon, 29 Jul 2019 14:16:35 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 18B8722245; Mon, 29 Jul 2019 08:16:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 29 Jul 2019 08:16:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=PCk5p0YB3DBXzYt/D7RjgGY3a5hqcFJKPIvrV+HMF88=; b=WZwF1S3MB76q Q7r0wWxRjnP1lwMsdpop08T/nKa9cmuFlWEWi98pQByBtJHM/aRbjanxh559C46U yLBzZy5GY74h1CT8Mbk4SuN8b7Pxa03ARovb3+ngLrIkhNqMAhwqYtoaRf85MuqK E9fOlV8Hz2RITuF1zhxxVoL2ZSleIMg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=PCk5p0YB3DBXzYt/D7RjgGY3a5hqcFJKPIvrV+HMF 88=; b=k4U/UInGxQmsd31OFe+ix1SF+HywSPkrZA6ocrPOH+C6CsGqIcIMwhCBu bYdkqnY16rTmzFbbQdc7uCNN0YZmxiDkoSH+EUVwVF8xwJLQ+9mxMSSch4sqOmnr Rp1kK209tuZEgh1l0VLepKmZ7FCShmDsVx/PFQr+Hd5b7de6pzOP99fjimXiEIZz DR6yfyoXaxphxe4pT1+SEGtSte0ZTlj2GhlbPKu1v+3FglalSCL+2ySQGLvwIGLU 2sw77zfiShaA/12SN4eEiAOVvjexxfKV4jmsXW4ei8j8QJcMF0u5I18IyKzzMTto fSw/AamLQEZ8y8akzJFgj9Z2Ql6cg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrledugdehtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (unknown [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 596B9380079; Mon, 29 Jul 2019 08:16:32 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev Date: Mon, 29 Jul 2019 14:15:50 +0200 Message-ID: <1605746.aTWFI4qxfl@xps> In-Reply-To: References: <20190717112031.10968-1-thomas@monjalon.net> <20190717155202.1674-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/2] devtools: restore null test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/07/2019 12:35, David Marchand: > On Wed, Jul 17, 2019 at 5:53 PM Thomas Monjalon wrote: > > --- a/devtools/test-null.sh > > +++ b/devtools/test-null.sh > > -if grep -q SHARED_LIB=y $build/.config; then > > - pmd='-d librte_pmd_null.so' > > +testpmd=$build/app/dpdk-testpmd > > +[ -f "$testpmd" ] || testpmd=$build/app/testpmd > > +if [ ! -f "$testpmd" ] ; then > > You don't really care that testpmd is a file, prefer -e. Yes I care, I want to avoid finding a directory. > > + echo 'ERROR: testpmd cannot be found' >&2 > > + exit 1 > > +fi > > + > > +unset libs > > You reference it later, I suppose you meant libs= I think "unset libs" is the standard syntax to initialize a variable to an empty value. > > +if ldd $testpmd | grep -q librte_ ; then > > + libs='-d librte_mempool_ring.so -d librte_pmd_null.so' > > fi