From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 0/8] vhost-user live migration support Date: Mon, 22 Feb 2016 10:56:42 +0100 Message-ID: <1606367.cIK8dmaxrY@xps13> References: <1450321921-27799-1-git-send-email-yuanhan.liu@linux.intel.com> <2602035.hWpncUurjs@xps13> <20160222070824.GY21426@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Victor Kaplansky , "Michael S. Tsirkin" To: Yuanhan Liu Return-path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 563EE567E for ; Mon, 22 Feb 2016 10:58:50 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id c200so162320627wme.0 for ; Mon, 22 Feb 2016 01:58:50 -0800 (PST) In-Reply-To: <20160222070824.GY21426@yliu-dev.sh.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-02-22 15:08, Yuanhan Liu: > On Fri, Feb 19, 2016 at 04:01:25PM +0100, Thomas Monjalon wrote: > > 2016-01-29 12:57, Yuanhan Liu: > > > This patch set adds the vhost-user live migration support. > > > > > > The major task behind that is to log pages we touched during > > > live migration, including used vring and desc buffer. So, this > > > patch set is basically about adding vhost log support, and > > > using it. > > > > > > Another important thing is that you need notify the switches > > > about the VM location change after migration is done. GUEST_ANNOUNCE > > > feature is for that, which sends an GARP message after migration. > > > For older kernel (<= v3.4) without GUEST_ANNOUNCE support, > > > we construct and broadcast a RARP message, with the mac address > > > from VHOST_USER_SEND_RARP payload. > > > > > > Patchset > > > ======== > > > - Patch 1 handles VHOST_USER_SET_LOG_BASE, which tells us where > > > the dirty memory bitmap is. > > > > > > - Patch 2 introduces a vhost_log_write() helper function to log > > > pages we are gonna change. > > > > > > - Patch 3 logs changes we made to used vring. > > > > > > - Patch 4 logs changes we made to vring desc buffer. > > > > > > - Patch 5 and 7 add some feature bits related to live migration. > > > > > > - patch 6 does the RARP construction and broadcast job. > > > > Patches 2 and 3 have been merged to avoid a compilation error. > > Applied, thanks > > Actually, there was a ongoing discussion about patch 6, the handling > of VHOST_USER_SEND_RARP request: > > http://dpdk.org/ml/archives/dev/2016-February/033539.html > > Maybe you have seen that and I didn't make it clear; my bad. Since you > have already applied it. I will make a standalone patch, and try to > send it out today. Yes I've wrongly understood there was no problem. The series would have not been applied if you had said that a new version was needed or if you had set the patchwork status to "Changes Requested". Sorry, we'll do better next times ;)