From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] examples: fix ip_pipeline makefile typo
Date: Tue, 17 Jan 2017 18:22:29 +0100
Message-ID: <1606457.4zG12SYGZt@xps13>
References: <CAKh5naZ8aOmiN0WkrGKe8J7Mt0R604hhR08PpgAbdwO=6u6M0Q@mail.gmail.com>
 <18c98c3f-f104-f9a6-f043-5c0421542c51@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>, matvejchikov@gmail.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f48.google.com (mail-lf0-f48.google.com
 [209.85.215.48]) by dpdk.org (Postfix) with ESMTP id 507BB108F
 for <dev@dpdk.org>; Tue, 17 Jan 2017 18:22:32 +0100 (CET)
Received: by mail-lf0-f48.google.com with SMTP id v186so113908427lfa.1
 for <dev@dpdk.org>; Tue, 17 Jan 2017 09:22:32 -0800 (PST)
In-Reply-To: <18c98c3f-f104-f9a6-f043-5c0421542c51@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-11-23 15:43, Ferruh Yigit:
> On 11/23/2016 12:56 PM, Ilya Matveychikov wrote:
> > Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
> > ---
> >  examples/ip_pipeline/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/examples/ip_pipeline/Makefile b/examples/ip_pipeline/Makefile
> > index 5827117..6657237 100644
> > --- a/examples/ip_pipeline/Makefile
> > +++ b/examples/ip_pipeline/Makefile
> > @@ -36,7 +36,7 @@ endif
> >  # Default target, can be overridden by command line or environment
> >  RTE_TARGET ?= x86_64-native-linuxapp-gcc
> > 
> > -DIRS-(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline
> > +DIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline
> 
> No need to fix, this line can be removed completely.
> 
> Because of:
> VPATH += $(SRCDIR)/pipeline
> 
> and files handled in this makefile:
> SRCS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline_passthrough.c
> 
> When you fix DIR-y, you also need to add a makefile to pipeline folder
> and update this makefile. I guess all those are not required. Just
> removing that line is easier J

There was no progress on this trivial patch.
So I made what Ferruh suggested and applied in the tree directly:
	http://dpdk.org/commit/45e1c8b

Thanks for the report and the review.