From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] app/testpmd: fix print unused parameter name
Date: Mon, 14 May 2018 12:51:19 +0200
Message-ID: <16071614.gU1QWOxn58@xps>
References: <20180514032048.34896-1-zhiyong.yang@intel.com>
 <VI1PR0501MB260873C11D7649049B42C4A4D29C0@VI1PR0501MB2608.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Matan Azrad <matan@mellanox.com>,
 "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
 "stable@dpdk.org" <stable@dpdk.org>
To: "zhiyong.yang@intel.com" <zhiyong.yang@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <VI1PR0501MB260873C11D7649049B42C4A4D29C0@VI1PR0501MB2608.eurprd05.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

14/05/2018 12:38, Matan Azrad:
> 
> Hi 
> 
> From: zhiyong.yang@intel.com
> > The second parameter "name" in the function rte_eth_dev_detach has been
> > already redefined as "char *name __rte_unused", "port_id" is printed instead
> > of "name" in testpmd.
> > 
> > Fixes: b65ecf199324 ("devargs: rename legacy API")
> > Cc: stable@dpdk.org
> 
> Really minor : Missing empty line here.
> 
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> Acked-by: Matan Azrad <matan@mellanox.com>

Title: app/testpmd: fix log after detach

Applied, thanks