From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v1] doc: update release notes for 18.11
Date: Mon, 26 Nov 2018 15:53:19 +0100
Message-ID: <16076895.T6Vh9qAcTW@xps>
References: <1543229461-80418-1-git-send-email-john.mcnamara@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, marko.kovacevic@intel.com
To: John McNamara <john.mcnamara@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id D8CE71B608
 for <dev@dpdk.org>; Mon, 26 Nov 2018 15:53:22 +0100 (CET)
In-Reply-To: <1543229461-80418-1-git-send-email-john.mcnamara@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi John,

Thanks for the update.
I have a couple of comments below.

26/11/2018 11:51, John McNamara:
>  * **Updated the AESNI MB PMD.**
>  
> -  The AESNI MB PMD has been updated with additional support for AES-GCM
> -  algorithm support.
> -
> -* **Added NXP CAAM JR PMD.**
> -
> -  Added the new caam job ring driver for NXP platforms. See the
> -  "NXP CAAM JOB RING (caam_jr)" document for more details on this new driver.
> +  The AESNI MB PMD has been updated with additional support for the AES-GCM
> +  algorithm.
>  
>  * **Added support for Dynamic Huffman Encoding to Intel QAT comp PMD.**
>  
>    The Intel QuickAssist (QAT) compression PMD has been updated with support
>    for Dynamic Huffman Encoding for the Deflate algorithm.
>  
> +* **Added NXP CAAM JR PMD.**
> +
> +  Added the new caam job ring driver for NXP platforms. See the
> +  "NXP CAAM JOB RING (caam_jr)" document for more details on this new driver.
> +

The CAAM JR is a crypto PMD, so I think it should be listed before
Huffman Encoding, which is a compression PMD.
We could also use the syntax :doc: to refer to its guide.

[...]
> +* ``AVX-512`` support has been disabled for ``GCC`` builds [1] because of a
> +  crash [2]. This can affect ``native`` machine type build targets on the
> +  platforms that support ``AVX512F`` like ``Intel Skylake`` processors, and
> +  can cause a possible performance drop. The immediate workaround is to use
> +  ``clang`` compiler on these platforms. The issue has been identified as a
> +  GCC defect and reported to the GCC community [3]. Further actions will be
> +  taken based on the GCC defect result.
>  
>    [1]: Commit 8d07c82b239f ("mk: disable gcc AVX512F support")
>    [2]: https://bugs.dpdk.org/show_bug.cgi?id=97

The references appear on the same line in HTML. Should we make them a list?