From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 1/3] ethdev: define ctrl_pkt filter type and its structure Date: Thu, 30 Oct 2014 23:47:10 +0100 Message-ID: <1607705.DDyl0z8Nv8@xps13> References: <1411628369-29532-1-git-send-email-jingjing.wu@intel.com> <1413965977-15165-1-git-send-email-jingjing.wu@intel.com> <1413965977-15165-2-git-send-email-jingjing.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Jingjing Wu Return-path: In-Reply-To: <1413965977-15165-2-git-send-email-jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-10-22 16:19, Jingjing Wu: > +/** > + * Define all structures for Control Packet Filter type corresponding with specific operations. > + */ Please explain what is a control packet. > + > +#define RTE_CONTROL_PACKET_FLAGS_IGNORE_MAC 0x0001 > +#define RTE_CONTROL_PACKET_FLAGS_DROP 0x0002 > +#define RTE_CONTROL_PACKET_FLAGS_TO_QUEUE 0x0004 > +#define RTE_CONTROL_PACKET_FLAGS_TX 0x0008 > +#define RTE_CONTROL_PACKET_FLAGS_RX 0x0000 Flag RX is 0? > +/** > + * A structure used to define the control packet filter entry > + * to support RTE_ETH_FILTER_CTRL_PKT with RTE_ETH_FILTER_ADD > + * and RTE_ETH_FILTER_DELETE operations. > + */ > +struct rte_ctrl_pkt_filter { > + struct ether_addr mac_addr; /**< mac address to match. */ > + uint16_t ether_type; /**< ether type to match */ > + uint16_t flags; /**< options for filter's behavior*/ > + uint16_t dest_id; /**< destination vsi id or pool id*/ vsi id and pool id cannot be understood in a generic context. Please explain what you mean and why queue is not enough. > + uint16_t queue; /**< queue assign to if TO QUEUE flag is set */ TO QUEUE is not defined. Is it really needed? Thanks -- Thomas