From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH v3] net/mlx4: fix dev rmv not detected after port stop Date: Tue, 30 Jan 2018 10:21:17 +0100 Message-ID: <1608356.uQtoRR8JKj@xps> References: <1516357009-15463-1-git-send-email-motih@mellanox.com> <1517214877-126768-1-git-send-email-motih@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: stable@dpdk.org, Shahaf Shuler , Adrien Mazarguil , "dev@dpdk.org" To: Mordechay Haimovsky Return-path: In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/01/2018 11:54, Shahaf Shuler: > Mordechay Haimovsky, Monday, January 29, 2018 10:35 AM: > > In failsafe device start can be called for ports/devices that had been plugged > > out. > > The mlx4 PMD detects device removal by listening to the device RMV events, > > when the mlx4 port is being stopped, the PMD no longer listens to these > > events causing the PMD to stop detecting device removals. > > This patch fixes this issue by moving installation of the interrupt handler to > > device configuration, and toggle only the Rx-queue interrupts on start/stop. > > > > Fixes: a6e8b01c3c26 ("net/mlx4: compact interrupt functions") > > Cc: stable@dpdk.org > > > > Signed-off-by: Moti Haimovsky > > Acked-by: Shahaf Shuler > > Adrien - let me know if you see issues with this patch, I want to include it on RC2. Applied, thanks